Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Royal Marines Commando #4098

Merged
merged 97 commits into from
Sep 8, 2023
Merged

Conversation

spartanbobby
Copy link
Contributor

@spartanbobby spartanbobby commented Aug 3, 2023

About the pull request

This PR adds the Royal Marines Commando under the TWE as a faction and as an ERT, this PR is part 1 and more is planned to be added the reason why it isn't being added in this PR is that it isn't fully complete and these sprites have been waiting a very long time

Royal Marines Roles

Smartgunner: Special smart-gun sprite, gameplaywise only difference is its use of holo targetting rounds on top of its regular ammo, making it a menace in a group

Breacher: The breacher combines his high armor with a ballistic shield and a rifle built to be used in one hand. This guy is hard to bring down

Marksman: The marksman rifle is limited to 20 rounds from 30 but has increased damage and a mini scope with no slowdown

Rifleman: The grunts of the three world empire are highly maneuverable their rifle while slower firing and only containing 30 rounds has no movement slowdown

Teamleader/Officer: the leaders are basically the same as the rifleman but with better skills and a VP78

The Royal Marines are equipped for every possibility in the field, they are all trained medics and carry the equipment to boot. Aside from the breacher, they are all quick on their feet, and their weapons while across the board slower than their marine equivalents pack the punch needed to get the job done.

Fluff, the royal marines in this area are based out of the HMS Patna working alongside the HMS Thunderchild to assist the United Americas in protecting the outer colonies from increasing CLF activity

Explain why it's good for the game

Gives the TWE some representation, adds some cool new faction stuff, an ERT, and equipment

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Triiodine, Frans, Warfan, SpartanBobby, Twomper, Roboticpotato, Tophat Penguin,forest2001
add: Added Royal Marines commando ERT and faction
add: Updates Riot shield sprite, adds metal shield as well (sprites from trio)
add: TWE ERT station
add: F903 Rifle, Royal marines commando armour sets, new smartgun with holotargetting rounds for royal marines commando
add: Calico shotgun, pistol and SMG sprites to the codebase made by Triodine
add: royal marines commando HEDP and HIDP grenades
/:cl:

# Conflicts:
#	icons/mob/humans/onmob/items_lefthand_0.dmi
#	icons/mob/humans/onmob/items_lefthand_1.dmi
#	icons/mob/humans/onmob/items_righthand_0.dmi
#	icons/mob/humans/onmob/items_righthand_1.dmi
#	icons/mob/humans/onmob/suit_1.dmi
#	icons/mob/humans/onmob/uniform_0.dmi
#	icons/obj/items/clothing/cm_hats.dmi
#	icons/obj/items/clothing/cm_suits.dmi
#	icons/obj/items/clothing/uniforms.dmi
#	icons/obj/items/weapons/guns/attachments/barrel.dmi
@spartanbobby spartanbobby marked this pull request as draft August 3, 2023 05:00
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 3, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge labels Aug 3, 2023
@spartanbobby spartanbobby marked this pull request as ready for review August 3, 2023 05:00
# Conflicts:
#	icons/mob/humans/onmob/back.dmi
#	icons/mob/humans/onmob/items_lefthand_0.dmi
#	icons/mob/humans/onmob/items_righthand_0.dmi
#	icons/obj/items/clothing/backpacks.dmi
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 3, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@spartanbobby spartanbobby marked this pull request as draft August 3, 2023 05:52
@spartanbobby spartanbobby marked this pull request as ready for review August 3, 2023 07:14
@spartanbobby spartanbobby marked this pull request as ready for review September 3, 2023 01:29
code/game/objects/items/storage/backpack.dm Outdated Show resolved Hide resolved
code/game/objects/items/storage/belt.dm Outdated Show resolved Hide resolved
code/modules/clothing/shoes/marine_shoes.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/royal_marines.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/royal_marines.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/royal_marines.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/royal_marines.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/royal_marines.dm Outdated Show resolved Hide resolved
code/datums/emergency_calls/royal_marines.dm Outdated Show resolved Hide resolved
code/datums/emergency_calls/royal_marines.dm Outdated Show resolved Hide resolved
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Sep 8, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Sep 8, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@harryob harryob added the Mapping Approved adds 500 new dict keys label Sep 8, 2023
@harryob harryob added this pull request to the merge queue Sep 8, 2023
Merged via the queue into cmss13-devs:master with commit a1079f4 Sep 8, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants